-
Notifications
You must be signed in to change notification settings - Fork 5
First draft of feature-netapp-trident #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
2d9d5c9
to
f3af9f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
- name: iscsi.service | ||
enabled: true | ||
- name: multipathd.service | ||
enabled: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On SNO clusters, would this cause a reboot? Then subsequent operations might fail due to the API going down? Maybe wait for the pool to stabilize? Example for that is here:
https://github.com/DanielFroehlich/stormshift-automation/blob/4c216034ef72e5733a1dfabd188f85ac75276a6b/roles/feature-workload-partitioning/tasks/post-deploy.yaml#L32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uf that's not so easy / time consuming. Because If have to patch master, wait... patch worker, wait...
backendType: "ontap-nas" | ||
provisioningType: "thin" | ||
snapshots: "true" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add some wait task here for everything to stabilize and be ready? I could image that this feature is one of the first in the sequence, because subsequent feature like RHOAI need storage, and it would be nice if those then do not fail. Eg. wait for the operator pod to be ready, or some of the Trident CRs maybe report a nice status we could wait for to be reached?
f3af9f1
to
d7b3c13
Compare
d7b3c13
to
5c3d436
Compare
#93